Edits to the Guided Sandbox to Address YB's comments#18
Edits to the Guided Sandbox to Address YB's comments#18danieljfeller wants to merge 15 commits intomainfrom
Conversation
|
lgtm |
|
@adrish-rhino all yours for the final changes |
ghost
marked this pull request as ready for review
yuvalrhino
left a comment
yuvalrhino
left a comment
There was a problem hiding this comment.
@adrish-rhino It's a bit hard for me to know what is actually going to be shown to users. I see some screenshots that still have the word "Cohort" in them, but then there's usually an equivalent version with "Dataset".
For notebooks - we usually clear outputs before putting this in the user-resources repo so that users don't see the outputs, execution count, etc. from when we ran the code.
Also - I'm assuming you've run this end to end to verify that it works properly, right?
|
We have to fix few diagrams here and in zendesk. Drew tested it before, I would like Daniel to test one more time since the last test was in Feb. We added task in commercial sprint and have plan to complete this by May 17th. |
4 participants
Click here for the SDK renaming reference table
Adrish needs to do two things upon his return:
#1 Sandbox instances need to be pre-loaded with Chest X-rays (
/rhino_data/image/dicom) and associated metadata ('/rhino_data/image/metadata/aidev_cohort.csv').#2 Create a mechanism for “Dr. Jones” (Health System persona) to auto-accept project invitations. Users SHOULD NOT need to wait for a Rhino team member to approve their invitation to proceed with the Sandbox project.
A few things that I could use your help with @ori Ashush
#1 Replacing all container calls with General Compute where the sandbox user can see the Python doing the data transformation, model training, or evaluation. 🙏
#2 Fixing the image links. You’ll see screenshots in user-resources/sandbox/pneumonia-prediction/images/ If any image links in the notebooks are broken, please fix them. I tried and failed to do so. 🚨
#3 Yaron recommended changing all the settings for links to other rhino docs (e.g. FL, FCP, Project, etc.) so they open in a new tab rather than the same tab to reduce the risk of derailing the flow. I wasn't able to figure out how to do this 😢 so please help me if nothing else!
#4 Add Tensorboard to notebook #4 if you want to try it 🧠